fix: regression from #1123 #1554
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since we are building the regex with `new RegExp`, the escapes must be double-escaped. Instead of `\.` to esape the period, we need `\\.`. Because that was not done, we were simply checking for *any* character, instead of a literal period.
|
Deploy preview for netlify-cms-www ready! Built with commit 74f9429 |
|
Deploy preview for cms-demo ready! Built with commit 74f9429 |
7 tasks
erquhart
approved these changes
Jul 31, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
- Summary
#1123 introduced a bug, where, instead of trimming the file extension with a preceding period from the end of a filename to get a slug, it trims the file extension plus one character, regardless of whether it was actually a period or not.
This is why we use linters!
- Test plan
- Description for the changelog
- A picture of a cute animal (not mandatory but encouraged)