Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): slug overwrite #2139

Merged
merged 2 commits into from
Apr 10, 2019
Merged

fix(core): slug overwrite #2139

merged 2 commits into from
Apr 10, 2019

Conversation

barthc
Copy link
Contributor

@barthc barthc commented Mar 4, 2019

Summary
Closes #1164, fix extracted from #1931

@netlify
Copy link

netlify bot commented Mar 4, 2019

Preview proposed changes to the CMS demo site in the link below:

Built with commit 3919e60

https://deploy-preview-2139--cms-demo.netlify.com

@netlify
Copy link

netlify bot commented Mar 4, 2019

Preview proposed changes to netlifycms.org in the link below:

Built with commit 3919e60

https://deploy-preview-2139--netlify-cms-www.netlify.com

Copy link
Contributor

@erquhart erquhart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great @barthc, thanks! Just a couple of discussion points added before we can merge.

@barthc
Copy link
Contributor Author

barthc commented Mar 14, 2019

@erquhart another look pls.

@barthc barthc force-pushed the 1164-fix-slug-overwrite branch from 96fb693 to 3919e60 Compare March 20, 2019 13:21
@erquhart erquhart merged commit 0ce995d into master Apr 10, 2019
@erquhart
Copy link
Contributor

@barthc we'll get this into today's beta release 👍

@erquhart erquhart deleted the 1164-fix-slug-overwrite branch April 10, 2019 20:39
@barthc
Copy link
Contributor Author

barthc commented Apr 10, 2019

@erquhart thanks for merging this, really appreciate it 👍

@erquhart
Copy link
Contributor

No problem, thanks for getting it in! It's now in the latest beta release npm install netlify-cms@beta.

Sent with GitHawk

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Prevent overwriting existing file
2 participants