Editorial Workflow support for GitLab #2409
Conversation
Branches - Included `collection` and `slug` in branch name, to avoid conflicts between collections Merge Requests - Changes to the branch are allowed, so HEAD is not checked against metadata Edge - Replaced `finally` with `then` and `recover`, as it is not (yet) supported
|
Preview proposed changes to netlifycms.org in the link below: Built with commit 738c4f9 |
|
Preview proposed changes to the CMS demo site in the link below: Built with commit 738c4f9 |
|
Is there a roadmap or plan for this feature development? I am willing to contribute with a little feedback on current intentions (Note: I haven't contributed to Netlify before but I work with GitLab extensively) |
|
Just needs to be completed and tested thoroughly - backend API methods have very few tests currently, so merging as is isn't safe. Also, a lot of the code was copy/pasted from the GitHub backend, which lowers my confidence, as GitHub and GitLab certainly have API differences. Some bugs are documented in comments on the original PR #1817, such as pull request merging not taking into account open/unresolved discussions, likely a symptom of reusing GitHub backend code. |
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
|
Linking this to #568 for contextual awareness. |
|
Closing in favor of #3014 |
Replaces #1817 (abandoned).
The code in this PR was authored by a community contributor, with the intent to add editorial workflow support for the GitLab backend.
This PR needs proper testing both in code and in practice to ensure against regressions. It's also highly likely that more work needs to be done in general, but again, that's difficult to ascertain without testing.
Rebased onto latest master as of 6/26/19, which provides some regression tests.