Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: bundle workflow changes #3156

Closed
wants to merge 7 commits into from
Closed

Conversation

barthc
Copy link
Contributor

@barthc barthc commented Jan 28, 2020

Closes #1025

Just like #1025 (comment) suggested, switched the workflow drag and drop from react-dnd to react-beautiful-dnd to take advantage of the combine feature.

Dragging an entry over another entry or already combined entries simply bundle all entries into a single PR. Some UI changes in the workflow page for combine entries card. Made use of react-tabs to make sure each combine entry card can still be viewed and edited.

This feature currently does not work for github backend. Will add support once we move the github workflow to labels.

@barthc barthc force-pushed the feat/bundle-workflow-changes branch from 8049a38 to 3a433b8 Compare January 28, 2020 19:35
@erezrokah
Copy link
Contributor

Hi @barthc, that you for this. We would like to re-visit this after we do some groundwork on the GitHub backend to align it with the other backends in regards with pagination and metadata handling. We also might wait until we finish multi-language support.

@barthc barthc closed this Oct 23, 2020
@martinjagodic martinjagodic deleted the feat/bundle-workflow-changes branch April 28, 2023 13:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bundle editorial workflow changes into one review branch
2 participants