media_folder on widged level #492
Conversation
docs/quick-start.md
Outdated
| @@ -110,6 +110,16 @@ This configuration adds a new setting, `public_folder`. While `media_folder` spe | |||
|
|
|||
| >If `public_folder` is not set, Netlify CMS will default to the same value as `media_folder`, adding an opening `/` if one is not included. | |||
|
|
|||
| The same settings can be applied on Image/File widget if you store your file in different folders. | |||
There was a problem hiding this comment.
We want to keep things minimal in the quick start docs, but this information would be good in docs/widgets.md. Extra sections for the image and file widgets can be added, similar to how the relation widget has a separate section.
src/valueObjects/AssetProxy.js
Outdated
| @@ -39,20 +41,21 @@ AssetProxy.prototype.toBase64 = function () { | |||
| }); | |||
| }; | |||
|
|
|||
| export function createAssetProxy(value, fileObj, uploaded = false, privateUpload = false) { | |||
| export function createAssetProxy(value, fileObj, uploaded = false, field_config = null) { | |||
There was a problem hiding this comment.
field_config should be field for consistency with other parts of the codebase.
src/valueObjects/AssetProxy.js
Outdated
| const config = store.getState().config; | ||
| const media_folder = field_config && field_config.has('media_folder') ? field_config.get('media_folder') : config.get('media_folder'); | ||
| const public_folder = field_config && field_config.has('public_folder') ? field_config.get('public_folder') : '/' + media_folder; |
There was a problem hiding this comment.
These can shorten up a bit, e.g.:
const media_folder = field_config && field_config.get('media_folder') || config.get('media_folder');There was a problem hiding this comment.
I cannot see if your version has any sideeffects. I prefer longer but self-explaining version
|
Ok, changed ... cheers :) |
src/valueObjects/AssetProxy.js
Outdated
| const config = store.getState().config; | ||
| const media_folder = (field && field.has('media_folder')) ? field.get('media_folder') : config.get('media_folder'); | ||
| const public_folder = (field && field.has('public_folder')) ? field.get('public_folder') : '/' + media_folder; |
There was a problem hiding this comment.
public_folder now falls back to '/' + media_folder instead of config.get('public_folder')?
|
@vencax I pushed some changes to avoid having the asset proxy worry about the concept of a field, and some docs tweaks. Can you test it against your use case and confirm whether everything is working? |
erquhart
force-pushed
the
media_folder_on_widgets
branch
from
8988156
to
0abe3d4
Compare
erquhart
force-pushed
the
media_folder_on_widgets
branch
from
0abe3d4
to
414fb76
Compare
|
Some fixes due to copypaste was needed ... :) |
|
Ah! Great catches, thank you for that. |
|
@vencax I'm now thinking we should hold off on this. #350 is a big priority, and allowing multiple media directories becomes much more complex when the Media Library UI is in place. I'm writing up plans now, but the priority for this goes:
Apologies that I didn't already bring this up, didn't consider that there would be a conflict. Please chime in on #350 if you have thoughts on it. |
|
ok, i have what I need. It works. You have it in this PR. Do what you consider best for your comunity ... |
|
@vencax after #350, the goal of your PR would be addressed by allowing asset collections to be defined in the config, the same way that we have content collections currently. You would also be able to lock a widget to one or more specific asset collections, similar to what you're doing in this PR, except by asset collection name. Do you think that would work for your use case? |
|
@erquhart I also really need this for making Netlify CMS play with Gatsby nicely. Since an implementation for #350 has been merged, is it now possible to have multiple asset collections and lock a widget to one asset collection as you describe? I tried to find some documentation about this, but couldn't. |
Some of webs has divided uploads into separate folders so the media_folder settings needs to be on widget level. This PR solves this without change of original behaviour.
It might be useful for others as well.
Cheers :)