Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Docs: Configuration “beta-features” #4969

Conversation

martinjagodic
Copy link
Member

Automatically generated by Netlify CMS

@martinjagodic martinjagodic requested a review from a team February 18, 2021 09:49
Copy link
Contributor

@erezrokah erezrokah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @martinjagodic for the PR. Good point about clarifying the expected structure.
Please let me know what you think about my comment.

@@ -614,3 +612,5 @@ collections:
# moving an existing entry will move the entire sub tree of the entry to the new location
meta: { path: { widget: string, label: 'Path', index_file: 'index' } }
```

**Note:** Nested collections work poperly only with `slug/index.md` directory structure. If you use `slug.md` approach, you might see some unwanted results.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure what slug.md approach means.
Could we rephrase it as Nested collections expect the following directory structure.... and provide something like this:

content
└── pages
    ├── authors
    │   ├── author-1
    │   │   └── index.md
    │   └── index.md
    ├── index.md
    └── posts
        ├── hello-world
        │   └── index.md
        └── index.md

Will that make it more clear?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@erezrokah thanks for your review. Your suggestion makes more sense, so I changed the content accordingly. I spent quite some time dealing with this before I realized that this structure is required. So I opened this PR to maybe save someone else's time.

Would it be possible to make this work with this sort of structure? It's what I meant with slug.md. If it's possible, I would be glad to open an issue, maybe even a pull request.

content
└── pages
    ├── authors
    │   ├── author-1.md
    │   └── index.md

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would it be possible to make this work with this sort of structure? It's what I meant with slug.md. If it's possible, I would be glad to open an issue, maybe even a pull request.

Opening an issue will be a great start. A pull request will be 🔥

@erezrokah erezrokah merged commit 7129253 into decaporg:master Feb 18, 2021
@martinjagodic martinjagodic deleted the cms/martinjagodic/netlify-cms/docs_configuration/beta-features branch February 18, 2021 12:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants