Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suggestion for adding Gatsby JS #527

Merged
merged 2 commits into from
Aug 17, 2017
Merged

Suggestion for adding Gatsby JS #527

merged 2 commits into from
Aug 17, 2017

Conversation

kalinchernev
Copy link
Contributor

- Summary

I was recently trying to integrate NetlifyCMS with Netlify service and Gatsby.js. I found an open issue on Gatsby's repo on possible GUI for the app. I'm still in the process of making both work well, though since I also found an article on your blog and given the increasing interest in the JAM stack, I decided this suggestion might be useful :)

- Test plan

Simple updates in documentation :)

- Description for the changelog

Notes for integrating with Gatsby statis site generator.

- A picture of a cute animal (not mandatory but encouraged)

Copy link
Contributor

@Benaiah Benaiah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Hexo, Middleman | `/source`
Spike | `/views`

Notes:
- Gatsby treats `static` folder more strictly and will not render the admin page as the others. You will have to make a [page component](https://www.gatsbyjs.org/docs/building-with-components/) contining the necessary contents of the admin page. However, the `config.yml` is to be placed in the `static` folder in the same way.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple quick typo fixes:

  • "Gatsby treats the static folder..." (add "the")
  • "containing the necessary contents..." (fix spelling of "containing")

Otherwise LGTM!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@verythorough thanks for the remarks! Well noticed!

Copy link
Contributor

@erquhart erquhart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@erquhart erquhart merged commit c3b3e5d into decaporg:master Aug 17, 2017
@kalinchernev kalinchernev deleted the patch-1 branch August 17, 2017 17:31
@kalinchernev
Copy link
Contributor Author

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants