fix(#6180): remove MS Office html comments #6818
Open
+108
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for decap-www canceled.
|
xaiki
reviewed
Oct 4, 2023
|
|
||
| import { markdownToSlate, htmlToSlate } from '../'; | ||
| import { htmlToSlate, markdownToSlate } from '../'; |
There was a problem hiding this comment.
these changes should probably not be part of this commit/pr
| @@ -182,6 +183,7 @@ export function htmlToSlate(html) { | |||
| const hast = unified().use(htmlToRehype, { fragment: true }).parse(html); | |||
|
|
|||
| const mdast = unified() | |||
| .use(rehypeRemoveComments, { removeConditional: true }) | |||
There was a problem hiding this comment.
this is what conditional comments are:
Conditional comments are a legacy feature that was specific to Internet Explorer. They were no longer used in IE 10.
maybe add a comment here documenting why what they are ?
|
@kav are you still interested in moving this forward? If yes, please address the comments and solve merge conflicts. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Pasting from Microsoft office is adding a large amount of cruft in the form of conditional comments. The commit removes comments from html paste. Confirmed code paths outside of the visual editor paste are not using that function so no unexpected html comment removal will occur.
Test plan
Added a test and confirmed functionality. Also reviewed codebase for other usage.
Checklist
Please add a
xinside each checkbox:A picture of a cute animal (not mandatory but encouraged)
fixes #6180