Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lerna -> nx, yarn -> npm #6959

Merged
merged 18 commits into from
Jan 31, 2024
Merged

Lerna -> nx, yarn -> npm #6959

merged 18 commits into from
Jan 31, 2024

Conversation

demshy
Copy link
Member

@demshy demshy commented Nov 3, 2023

Summary
This PR moves the project from an outdated Lerna to nx. Also moving from yarn to npm, since using yarn is no longer necessary for monorepos and between updating yarn to v3 or changing to npm we preferred the latter.
Some notes:

  • We entered beta state with Lerna so for versioning we will still use it (latest version though) and consider switching to changesets after the minor version release
  • Website is not affected by this PR because moving it from yarn was not trivial - this should be done in a separate PR later on

These changes should not affect the product in any way, only the workflow of contributors. From my end it does seem much smoother - especially with nx's caching, building and testing should now be much faster.

Test plan

Checklist

Please add a x inside each checkbox:

A picture of a cute animal (not mandatory but encouraged)

Copy link

netlify bot commented Nov 3, 2023

Deploy Preview for cms-demo ready!

Name Link
🔨 Latest commit d58f086
🔍 Latest deploy log https://app.netlify.com/sites/cms-demo/deploys/656f45f295caa40008757c2a
😎 Deploy Preview https://deploy-preview-6959--cms-demo.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Nov 14, 2023

Deploy Preview for decap-www canceled.

Name Link
🔨 Latest commit 7b1c104
🔍 Latest deploy log https://app.netlify.com/sites/decap-www/deploys/65ba0df7bcffb50008b00dca

martinjagodic
martinjagodic previously approved these changes Jan 31, 2024
@martinjagodic martinjagodic merged commit 7d47917 into master Jan 31, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants