Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Docs: migrate Beta Features - GraphQL APIs #7046

Merged

Conversation

privatemaker
Copy link
Contributor

Continuing migration of Beta Features Documentation #7040

@martinjagodic i'll stop here until I get a confirmation my workflow here works for you 😉

@privatemaker privatemaker requested a review from a team as a code owner January 19, 2024 12:25
Copy link

netlify bot commented Jan 19, 2024

Deploy Preview for decap-www ready!

Name Link
🔨 Latest commit 51949a7
🔍 Latest deploy log https://app.netlify.com/sites/decap-www/deploys/65ae3ec4d3bfbf0008366349
😎 Deploy Preview https://deploy-preview-7046--decap-www.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

website/content/docs/github-backend.md Outdated Show resolved Hide resolved
website/content/docs/gitlab-backend.md Outdated Show resolved Hide resolved
@privatemaker
Copy link
Contributor Author

Pushed your request and moved the Note: ... bit to bottom.

Copy link
Member

@martinjagodic martinjagodic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@privatemaker I would keep the note under title. It could be frustrating for someone to go over the tutorial and only then realising it's not compatible with their setup. What do you think?

@privatemaker
Copy link
Contributor Author

Hrm, if a user is interested in using github or gitlab backend, I assume user knows they are not using git-gateway as a backend. So why the need for the Note: ... at all?

But not that big of a deal. I moved it back under the header.

@martinjagodic martinjagodic merged commit 4e91a0b into decaporg:master Jan 22, 2024
16 checks passed
@privatemaker privatemaker deleted the docs/beta-features/graphql-api branch January 23, 2024 09:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants