Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Docs: refactor Collections & migrate Beta Features #7049

Conversation

privatemaker
Copy link
Contributor

Working towards #7040 I refactored the Collection Types group by splitting up into multiple files as that page was already bit long and would get very long adding in the Beta Features texts.

Also it seems silly to have a Group for a single file with only #anchor pages for deep linking.

I will mark this as a draft expecting some adjustments @martinjagodic

@privatemaker privatemaker requested a review from a team as a code owner January 19, 2024 13:58
Copy link

netlify bot commented Jan 19, 2024

Deploy Preview for decap-www ready!

Name Link
🔨 Latest commit 173e50b
🔍 Latest deploy log https://app.netlify.com/sites/decap-www/deploys/65ae2aeec66be20008a82e65
😎 Deploy Preview https://deploy-preview-7049--decap-www.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@privatemaker privatemaker marked this pull request as draft January 19, 2024 13:58
@privatemaker privatemaker marked this pull request as ready for review January 19, 2024 13:59
@privatemaker
Copy link
Contributor Author

I pushed another update I think makes more sense 😉

Copy link
Member

@martinjagodic martinjagodic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Although nested collections are technically folder collections, I agree that this is a separate file, as it's flagged as beta and the folder collection file would get too long.

@martinjagodic martinjagodic enabled auto-merge (squash) January 22, 2024 08:44
@martinjagodic martinjagodic merged commit cfc5fe0 into decaporg:master Jan 22, 2024
15 of 16 checks passed
@privatemaker privatemaker deleted the docs/refactor-collections-beta-features branch January 22, 2024 09:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants