Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Widget richtext #7162

Draft
wants to merge 14 commits into
base: main
Choose a base branch
from
Draft

Widget richtext #7162

wants to merge 14 commits into from

Conversation

demshy
Copy link
Member

@demshy demshy commented Mar 27, 2024

Summary
This is a work-in-progress PR that adds richtext-widget as a potential replacement for the markdown in one of the future releases. Discussion where I put some of my thoughts about this here: #6905
Digging deeper, there might be another caveat that we haven't considered before - nesting block types (inside lists for example) might make the implementation much more difficult so I did not go down that road yet.

A very rough checklist:

  • create new widget and install Plate
  • inline marks (bold, italics, and code)
  • headings
  • number and bullet lists
  • quote block
  • links
  • editor components / shortcodes
  • toggle markdown view
  • images
  • (new/bonus) tables
  • (new/bonus) drag&drop blocks

I have copied serializers (and their tests) from the existing markdown widget and am updating them as I go. I copy the renderers one by one as I get to the plugin in question.
Once the basic implementation is done, I plan on going through the e2e tests and update what is needed on the code or tests side, depends on the specific situation.

Note that this is very much in progress but I'm happy of any feedback, especially from someone who dealt with Slate/Plate before.

Test plan

Checklist

Please add a x inside each checkbox:

A picture of a cute animal (not mandatory but encouraged)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant