Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: nested fields and integer values for filter relation widget #7177

Merged
merged 1 commit into from
Apr 16, 2024

Conversation

JimmyOei
Copy link
Contributor

Summary

This PR for the relation widget adds functionality for nested fields in the filters and also allows integer types for the values in the filters.

  • Nested fields: it is now possible to have a filter like this: filters: [ { field: 'deeply.nested.field', values: ['Some text'] } ]
  • Integer type: values can now also be integers (before only booleans and strings were allowed): filters: [ { field: 'num', values: [1, 12, 20] } ]

Test plan

I added a unit test for the nested fields and for the integer type.

Checklist

Please add a x inside each checkbox:

A picture of a cute animal (not mandatory but encouraged)
IMG_0381

@demshy demshy merged commit 0e6f93b into decaporg:main Apr 16, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants