Fix login with Gitlab (change API Authorization header "token" → "Bearer")
#7242
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…Bearer" The authorization type "Bearer" is more widely recognized than "token". E.g. Gitlab requires that you use "Bearer". This should fix #7172 where apparently login with Github was broken by this line: #7172 (comment) See also: #5844 (comment)
4 tasks
martinjagodic
approved these changes
Jun 30, 2024
martinjagodic
pushed a commit
that referenced
this pull request
Aug 5, 2024
…Bearer" (#7242) The authorization type "Bearer" is more widely recognized than "token". E.g. Gitlab requires that you use "Bearer". This should fix #7172 where apparently login with Github was broken by this line: #7172 (comment) See also: #5844 (comment)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The authorization type "Bearer" is more widely recognized than "token". E.g. Gitlab requires that you use "Bearer".
Github mentions that it accepts both "token" and "Bearer": https://docs.github.com/en/rest/authentication/authenticating-to-the-rest-api?apiVersion=2022-11-28#about-authentication
Gitlab seems to require the use of "Bearer", which was apparently the cause of #7172: #7172 (comment) (thanks to @b-xb for digging into this)
See also: #5844 (comment)
Fixes #7172.
Summary
Gitlab login is broken in current versions: #7172
Test plan
Checklist
A picture of a cute animal (not mandatory but encouraged)
