fix(markdown): copying html into markdown #7290
Merged
+105
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Nice work on this! Just build a version with this merged in and it coped fine with the simple Google Doc I threw at it! Thanks for your efforts! |
mattcen
reviewed
Oct 24, 2024
| UL: () => ({ type: 'bulleted-list' }), | ||
| }; | ||
|
|
||
| // COMPAT: `B` is omitted here because Google Docs uses `<b>` in weird ways. |
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
There was a problem hiding this comment.
great catch.
Slate also noticed and updated this, so I just copied new version of example.
Should the comment, or the B mapping be removed?
Since it's known that Google Docs uses <b> differently, I would leave it removed as is
demshy
approved these changes
Nov 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #7233
Summary
When pasting html into markdown, keep styles instead of plain text.
Code copied from official example https://github.com/ianstormtaylor/slate/blob/main/site/examples/ts/paste-html.tsx
Test plan
Checklist
Please add a
xinside each checkbox:A picture of a cute animal (not mandatory but encouraged)
