Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add background-color to list widget #768

Merged
merged 1 commit into from
Nov 8, 2017
Merged

Add background-color to list widget #768

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 14 additions & 0 deletions src/components/Widgets/ListControl.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,6 +47,18 @@
border: none;
border-radius: var(--borderRadius) 0 0 var(--borderRadius);
background: rgba(0,0,0,0.1);

&:before {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Feels like this shouldn't be necessary - can't we just set the background color of the individual list items?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@erquhart this is for the tab with the arrow icon, it remains semi-transparent otherwise. But I can remove if it is not necessary.

content: '';
position: absolute;
z-index: -1;
top: 0;
left: 0;
width: 100%;
height: 100%;
background-color: var(--controlBGColor);
border-radius: var(--borderRadius) 0 0 var(--borderRadius);
}
}

.nc-listControl-item {
Expand All @@ -55,6 +67,7 @@
}

.nc-listControl-objectLabel {
background-color: var(--controlBGColor);
border: 2px solid rgba(0,0,0,0.1);
border-top-width: 28px;
border-radius: var(--borderRadius);
Expand All @@ -81,6 +94,7 @@
display: block;
border-top: 28px solid rgba(0,0,0,0.1);
border-top-left-radius: 0;
background-color: var(--controlBGColor);
}

.nc-listControl-collapsed {
Expand Down