Reduce potential sources of safe address to one + cleanup #2242
+529
−510
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for decent-interface-dev ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Debug reset safe state
mudrila
added
bug
…de-daoAddress `state-overhaul` | Trim down possible state location of safe address to `node.safe`
adamgall
commented
Nov 5, 2024
src/components/pages/DaoSettings/components/Signers/modals/AddSignerModal.tsx
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Need more eyes on this file. I'd like the changes here to be kept. They seem to be about cleaning up unnecessary arguments, plus a call to resetHatsStore(); when "resetting" safe state.
adamgall
commented
Nov 5, 2024
DarksightKellar
changed the title
Root / State overhaul…e`'s `formatDAOQuery`; rename to `getNodeInfo`
mudrila
approved these changes
Nov 7, 2024
adamgall
commented
Nov 11, 2024
adamgall
commented
Nov 12, 2024
There was a problem hiding this comment.
@DarksightKellar if there are no changes to package.json there should be no changes in this lock file either.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.