Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2270 update payments card #2338

Merged
merged 22 commits into from
Sep 12, 2024
Merged

2270 update payments card #2338

merged 22 commits into from
Sep 12, 2024

Conversation

Da-Colon
Copy link
Contributor

@Da-Colon Da-Colon commented Sep 9, 2024

Closes #2270

Screenshots

image

image

Copy link

netlify bot commented Sep 9, 2024

Deploy Preview for decent-interface-dev ready!

Name Link
🔨 Latest commit 974e7b9
🔍 Latest deploy log https://app.netlify.com/sites/decent-interface-dev/deploys/66e32c182b355e0008c196d6
😎 Deploy Preview https://deploy-preview-2338.app.dev.decentdao.org
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

@mudrila mudrila left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple minor points, but other than that - looks good

src/components/pages/Roles/RolePaymentDetails.tsx Outdated Show resolved Hide resolved
src/components/pages/Roles/RolePaymentDetails.tsx Outdated Show resolved Hide resolved
src/components/pages/Roles/RolesDetailsDrawer.tsx Outdated Show resolved Hide resolved
Copy link
Contributor

@mudrila mudrila left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bunch of optional micro-optimizations, apart of that everything looks good sir!

src/components/pages/Roles/RolePaymentDetails.tsx Outdated Show resolved Hide resolved
src/components/pages/Roles/RolesDetailsDrawer.tsx Outdated Show resolved Hide resolved
src/components/pages/Roles/RolesDetailsDrawerMobile.tsx Outdated Show resolved Hide resolved
@Da-Colon Da-Colon merged commit 6f83b97 into develop Sep 12, 2024
7 checks passed
@Da-Colon Da-Colon deleted the issue/2270-update-payments-card branch September 12, 2024 18:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update UI to match designs
4 participants