Rework useSnapshotProposal and usages #2345
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s, remove prop drilling
❌ Deploy Preview for decent-interface-dev failed. Why did it fail? →
|
DarksightKellar
changed the title
mudrila
approved these changes
Sep 12, 2024
| @@ -295,6 +294,7 @@ export interface NodeHierarchy { | |||
| } | |||
|
|
|||
| export type FractalProposal = AzoriusProposal | MultisigProposal | SnapshotProposal; | |||
| export type Activity = FractalProposal; | |||
There was a problem hiding this comment.
Seems like we can even remove type Activity and just use FractalProposal
There was a problem hiding this comment.
I'll gladly do it in this PR heh
adamgall
reviewed
Sep 12, 2024
adamgall
approved these changes
Sep 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While working on typechain fixes, I found some naming conventions hard to follow around proposal actions. While digging through the code, I noticed an old TODO recommending a refactor. Got lost in the sauce, did some light moving around and type tightening, and here we are -- a new PR.
Untested, but pls review. If changes make sense, I plan to test in the typechain branch.