This repository has been archived by the owner on Feb 21, 2024. It is now read-only.
[New Circuit] KV Membership circuit #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sethhrbek
approved these changes
Aug 30, 2023
| const pubKey = ec.keyFromPrivate(privKey.toString("hex")).getPublic(); | ||
|
|
||
| const hashPubKey = poseidon.hash([pubKey.x.toString("hex"), pubKey.y.toString("hex")]); | ||
| const hashSecret = poseidon.hash([secret, BigInt(0)]); |
There was a problem hiding this comment.
Could maybe leave a comment here or in the circuit about why padding is necessary
Comment on lines
9
to
12
| const SECP256K1_N = new BN( | ||
| "fffffffffffffffffffffffffffffffebaaedce6af48a03bbfd25e8cd0364141", | ||
| 16 | ||
| ); |
There was a problem hiding this comment.
What does this do? just curiousity, i see it used down below, assuming something related to the curve math
Comment on lines
96
to
101
| let serialized = new Uint8Array( | ||
| 32 + 1 + this.msgHash.byteLength + circuitPubInput.byteLength | ||
| ); | ||
|
|
||
| serialized.set(bigIntToBytes(this.r, 32), 0); | ||
| serialized.set(bigIntToBytes(this.rV, 1), 32); |
There was a problem hiding this comment.
could potentially make vars like:
const rLength = 32;
const rVLength = 1;
let serialized = new Uint8Array(
rLength + rVLength + this.msgHash.byteLength + circuitPubInput.byteLength
);
serialized.set(bigIntToBytes(this.r, rLength), 0);
serialized.set(bigIntToBytes(this.rV, rVLength), rLength);
...
Just to make it clear what each padding is for (but this is extremely minor)
| name: string; | ||
| version: string; | ||
| chainId: number; | ||
| // verifyingContract: PrefixedHex; |
sethhrbek
reviewed
Aug 30, 2023
packages/lib/package.json
Outdated
Comment on lines
28
to
30
| "snarkjs": "^0.5.0", | ||
| "ethers": "5", | ||
| "snarkjs": "^0.5.0", |
There was a problem hiding this comment.
@Da-Colon -- snarkjs is included twice here
christopherdancy
approved these changes
Aug 30, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This pull request introduces a new zk-SNARK circuit called
KVMembershipthat serves multiple purposes such as nullifier check, Merkle proof verification, and statement value validation. The circuit is implemented in Circom and leverages multiple components fromcircomlibas well as custom components likeEfficientECDSAandPoseidon. Unit tests have been added to ensure the prove and verify functions of the circuit work as expected.Features
Dependencies
Installation and Testing
Pre-requisites
circominstalled as its missing the README instructions. circomInstallation
Switch to the appropriate Node.js version by running the following command:
Follow the README instructions for setting up the environment and dependencies.
Testing
Run the test suite with the following command: