feat: update subscription module with email validation #356
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -47,14 +58,52 @@ describe('when reducing the get subscription success action', () => { | |||
| subscriptionDetails: { ...objectToCamel(subscription.details), ignoreAllInApp: true } | |||
| } | |||
| }) | |||
| describe('and there is no email nor unconfirmedEmail', () => { | |||
| it('should return a state with the default subscription details set without the email and the loading state cleared', () => { | |||
There was a problem hiding this comment.
Why is it the default subscription details? It's setting the subscription details that came with the action.
There was a problem hiding this comment.
can you check again?
LautaroPetaccio
approved these changes
May 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.