Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Ceate linked collection items support #3135

Merged
merged 7 commits into from
Jul 4, 2024

Conversation

LautaroPetaccio
Copy link
Contributor

This PR adds the support for creating linked collection items by:

  • Adding the capabilities to support the new URNs in the item creations modals.
  • Changes the way the single item creation modal works to not show the beneficiary and price step.
  • Refactors the way we're checking if an item is an emote or a wearable.

Copy link

vercel bot commented Jul 3, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
builder ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 3, 2024 9:04pm

@coveralls
Copy link

coveralls commented Jul 3, 2024

Pull Request Test Coverage Report for Build 9784747777

Details

  • 18 of 18 (100.0%) changed or added relevant lines in 4 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage increased (+0.008%) to 47.608%

Files with Coverage Reduction New Missed Lines %
src/modules/item/reducer.ts 1 41.67%
Totals Coverage Status
Change from base Build 9784712131: 0.008%
Covered Lines: 5554
Relevant Lines: 10691

💛 - Coveralls

@coveralls
Copy link

coveralls commented Jul 3, 2024

Pull Request Test Coverage Report for Build 9784755818

Details

  • 18 of 18 (100.0%) changed or added relevant lines in 4 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage increased (+0.008%) to 47.608%

Files with Coverage Reduction New Missed Lines %
src/modules/item/reducer.ts 1 41.67%
Totals Coverage Status
Change from base Build 9784712131: 0.008%
Covered Lines: 5554
Relevant Lines: 10691

💛 - Coveralls

@LautaroPetaccio LautaroPetaccio merged commit 66f1e98 into master Jul 4, 2024
7 checks passed
@LautaroPetaccio LautaroPetaccio deleted the feat/create-linked-collection-items-support branch July 4, 2024 14:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants