Skip to content

Commit

Permalink
fix: force libs installation
Browse files Browse the repository at this point in the history
  • Loading branch information
cyaiox committed Feb 14, 2025
1 parent c5659d0 commit 6121afb
Show file tree
Hide file tree
Showing 5 changed files with 17 additions and 4 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/drop.yml
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ jobs:
drop_pre_release:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@692973e3d937129bcbf40652eb9f2f61becf3332 # v4
- uses: actions/checkout@v4
- uses: actions/setup-node@v4
with:
cache: 'npm'
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/lint.yml
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,7 @@ jobs:
runs-on: ubuntu-latest

steps:
- uses: actions/checkout@692973e3d937129bcbf40652eb9f2f61becf3332 # v4
- uses: actions/checkout@v4
- uses: actions/setup-node@v4
with:
cache: 'npm'
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ jobs:
os: [ macos-latest, windows-latest ]
runs-on: ${{ matrix.os }}
steps:
- uses: actions/checkout@692973e3d937129bcbf40652eb9f2f61becf3332 # v4
- uses: actions/checkout@v4
- uses: actions/setup-node@v4
with:
cache: 'npm'
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/typechecking.yml
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ jobs:
runs-on: ubuntu-latest

steps:
- uses: actions/checkout@692973e3d937129bcbf40652eb9f2f61becf3332 # v4
- uses: actions/checkout@v4
- uses: actions/setup-node@v4
with:
cache: 'npm'
Expand Down
13 changes: 13 additions & 0 deletions packages/main/src/modules/bin.ts
Original file line number Diff line number Diff line change
Expand Up @@ -165,6 +165,19 @@ export async function install() {
// no need to install node and npm in dev mode since they should already be in the $PATH for dev environment to work
log.info('[Install] Skipping installation of node and npm binaries in DEV mode');
}
// TODO: remove this once we have merged the asset-packs PR
log.info('[CLI] Installing some dev dependencies...', { path });
for (const pkg of [
'https://sdk-team-cdn.decentraland.org/@dcl/js-sdk-toolchain/branch/feat/add-admin-toolkit-smart-item/dcl-sdk-7.7.5-13322726812.commit-b78f7c8.tgz',
'https://sdk-team-cdn.decentraland.org/@dcl/asset-packs/branch/feat/add-admin-toolkit-smart-item/dcl-asset-packs-2.1.3-13322708802.commit-059ee23.tgz',
]) {
const npmInstall = run('npm', process.platform === 'win32' ? 'npm.cmd' : 'npm', {
args: ['install', '--save-dev', pkg, '--loglevel', 'error'],
cwd: APP_UNPACKED_PATH,
workspace: APP_UNPACKED_PATH,
});
await npmInstall.wait();
}
installed.resolve();
} catch (error: any) {
log.error('[Install] Failed to install node and npm binaries:', error.message);
Expand Down

0 comments on commit 6121afb

Please sign in to comment.