feat: handle multiple previews at the same time

[gonpombo8]

also error handling when importing scene and its not accesible

[github-actions]

Test this pull request on windows-latest

Download the correct version for your architecture:

win-x64

[github-actions]

Test this pull request on macos-latest

Download the correct version for your architecture:

mac-arm64
mac-x64

Click here if you don't know which version to download

For running this unsigned version of the app, you will need to run the xattr command on it:

1. Extract the app from the downloaded .dmg file (double-click it)
2. Place the extracted app anywhere you like in your file system
3. Open a terminal on the directory where the app is
4. Run xattr -c app-name, replacing "app-name" for the actual name of the app
5. Double-click the app ✅

[cyaiox]

is it going to enter here when the fs.readdir throws an error?

In that case, should we skip the path because it isn't accessible?

[gonpombo8]

i was following the same approach as the code does when the path doesn't exist or its unaccessible.

      if (!(await exists(_path))) {
        // _path doesn't exist
        missing.push(_path);

[nicoecheza]

what do you think of something like this? just replaced the cache with a Map and added some types

interface PreviewData {
  child: Child;
  previewURL: string;
}

export const previewCache = new Map<string, PreviewData>();

export async function killPreview(path: string) {
  const preview = previewCache.get(path);
  if (preview?.child) {
    await preview.child.kill().catch(() => {});
  }
  previewCache.delete(path);
}

export async function killAllPreviews(): Promise<void> {
  const killPromises: Promise<void>[] = [];
  for (const preview of previewCache.values()) {
    killPromises.push(preview.child.kill().catch(() => {}));
  }

  await Promise.all(killPromises);
  previewCache.clear();
}

async function createPreviewProcess(path: string): Promise<PreviewData> {
  const child = run('@dcl/sdk-commands', 'sdk-commands', {
    args: ['start', '--explorer-alpha', '--hub'],
    cwd: path,
    workspace: path,
    env: await getEnv(path),
  });

  const dclLauncherURL = /decentraland:\/\/([^\s\n]*)/i;
  const resultLogs = await child.waitFor(dclLauncherURL, /CliError/i);
  const urlMatch = resultLogs.match(dclLauncherURL);

  return {
    child,
    previewURL: urlMatch?.[1] ?? '',
  };
}

export async function start(path: string, retry = true) {
  try {
    const existingPreview = previewCache.get(path);
    if (existingPreview?.child.alive() && existingPreview.previewURL) {
      await dclDeepLink(existingPreview.previewURL);
      return;
    }

    await killPreview(path);

    const preview = await createPreviewProcess(path);
    previewCache.set(path, preview);

  } catch (error) {
    previewCache.delete(path);
    if (retry) {
      log.info('[CLI] Something went wrong trying to start preview:', (error as Error).message);
      await install(path);
      await start(path, false);
    } else {
      throw error;
    }
  }
}

and replace killPreview with killAllPreview on packages/main/src/index.ts

[gonpombo8]

whats the diff between a map and a record ?

[gonpombo8]

moving everything to diff functions that only are used 1 time feels unnecessary imo

[cyaiox]

in Windows we have to use start "decentraland://${deepLink}", does the exec handle it automatically for each OS?

[gonpombo8]

YES !!!!!!!!!!!!!!! that was a TODO that totally forgot about! thanks gabi