Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: add gdscript linter and async-function-name linter #102

Merged
merged 7 commits into from
Nov 23, 2023
Merged

refactor: add gdscript linter and async-function-name linter #102

merged 7 commits into from
Nov 23, 2023

Conversation

kuruk-mm
Copy link
Member

@kuruk-mm kuruk-mm commented Nov 22, 2023 •
edited
Loading

@kuruk-mm kuruk-mm changed the title refactor: linter refactor: add gdscript linter and async-function-name linter Nov 22, 2023
@kuruk-mm kuruk-mm marked this pull request as ready for review November 22, 2023 19:17
leanmendoza
leanmendoza approved these changes Nov 23, 2023
View reviewed changes
godot/src/logic/realm.gd
@@ -19,6 +19,9 @@ static func dcl_world_url(dcl_name: String) -> String:


static func ensure_ends_with_slash(str_param: String) -> String:
if str_param.is_empty():
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice catch

godot/src/ui/components/backpack/backpack.gd Show resolved Hide resolved
@kuruk-mm kuruk-mm merged commit 649ffba into main Nov 23, 2023
3 checks passed
@kuruk-mm kuruk-mm deleted the refactor/linter branch November 23, 2023 18:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leanmendoza leanmendoza leanmendoza approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kuruk-mm @leanmendoza