Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: sdk7 apis #103

Merged
merged 6 commits into from
Nov 29, 2023
Merged

feat: sdk7 apis #103

merged 6 commits into from
Nov 29, 2023

Conversation

kuruk-mm
Copy link
Member

@kuruk-mm kuruk-mm commented Nov 22, 2023

  • RestrictedActions.openExternalUrl
  • Runtime.getRealm
  • Runtime.getWorldTime (return noon in seconds (60*60*12), this will be implemented better with the skybox)
  • Runtime.getSceneInformation

(deprecated API, support it)

  • Scene.getSceneInfo (reuse Runtime.getSceneInformation)
  • EnvironmentApi.getBootstrapData (not documented, sdk7 exposed, reuse Runtime.getSceneInformation)
  • EnvironmentApi.isPreviewMode (can reuse Runtime.getRealm, just mapping data)
  • EnvironmentApi.getPlatform (return { platform: 'desktop' })
  • EnvironmentApi.areUnsafeRequestAllowed (return { status: false })
  • EnvironmentApi.getCurrentRealm (can reuse Runtime.getRealm, just mapping)
  • EnvironmentApi.getExplorerConfiguration (return default values and empty map)
  • EnvironmentApi.getDecentralandTime (reuse RuntimeService.getWorldTime)

@kuruk-mm kuruk-mm changed the base branch from main to refactor/linter November 22, 2023 23:44
Base automatically changed from refactor/linter to main November 23, 2023 18:12
@codecov-commenter
Copy link

codecov-commenter commented Nov 23, 2023

Codecov Report

Attention: 176 lines in your changes are missing coverage. Please review.

Comparison is base (649ffba) 13.11% compared to head (f9f10e7) 12.94%.

Files Patch % Lines
...cene_runner/rpc_calls/handle_restricted_actions.rs 0.00% 58 Missing ⚠️
...t-lib/src/scene_runner/rpc_calls/handle_runtime.rs 0.00% 47 Missing ⚠️
rust/decentraland-godot-lib/src/dcl/js/runtime.rs 0.00% 33 Missing ⚠️
...traland-godot-lib/src/dcl/js/restricted_actions.rs 0.00% 21 Missing ⚠️
...aland-godot-lib/src/comms/communication_manager.rs 16.66% 5 Missing ⚠️
...raland-godot-lib/src/scene_runner/rpc_calls/mod.rs 0.00% 5 Missing ⚠️
...land-godot-lib/src/scene_runner/godot_dcl_scene.rs 0.00% 4 Missing ⚠️
rust/decentraland-godot-lib/src/dcl/scene_apis.rs 0.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #103      +/-   ##
==========================================
- Coverage   13.11%   12.94%   -0.17%     
==========================================
  Files         106      107       +1     
  Lines       13057    13238     +181     
==========================================
+ Hits         1712     1714       +2     
- Misses      11345    11524     +179     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kuruk-mm kuruk-mm marked this pull request as ready for review November 27, 2023 20:42
@kuruk-mm kuruk-mm requested a review from leanmendoza November 27, 2023 21:23
Copy link
Collaborator

@leanmendoza leanmendoza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!

@kuruk-mm kuruk-mm enabled auto-merge (squash) November 29, 2023 11:36
@kuruk-mm kuruk-mm merged commit 02397fd into main Nov 29, 2023
3 checks passed
@kuruk-mm kuruk-mm deleted the feat/sdk7-apis branch November 29, 2023 11:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants