-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: add visual snapshots and comparison #104
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leanmendoza
changed the title
test: add visuial snapshot and comparison
test: add visual snapshots and comparison
Nov 23, 2023
looks good, although the path being user:// is unix-centric. if we had user agent in engine info (or some other way to determine the client) we could have the screenshots as scene content. |
fix round for calculating gray color
leanmendoza
commented
Dec 5, 2023
leanmendoza
commented
Dec 5, 2023
kuruk-mm
approved these changes
Dec 6, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, minor reviews
add billboard BM_Y mode, BM_XY forward to ALL for now fix raycast origin_offset, and tick_number
change FORCE_TEST_REALM to gh pages fix warnings
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces a method in the
~system/Testing
API to generate a visual snapshot of the Scene and compare it with the existing one (if it applies).The current method for comparison is to compute the grayscale from the NTSC standard of each image (the stored snapshot and the just taken one), calculate the absolute difference, and then compute a standard deviation.
The similarity is 1.0, completely similar to 0.0, completely different.
branch test/snapshot
https://github.com/sdilauro/dae-unit-tests