-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: debug panel with console #114
Conversation
kuruk-mm
commented
Nov 30, 2023
•
edited
Loading
edited
- Fix focus problems
- Create right click dialog menu
…instead of copying those (only linux)
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #114 +/- ##
=======================================
Coverage 13.03% 13.03%
=======================================
Files 111 111
Lines 13874 13874
=======================================
Hits 1808 1808
Misses 12066 12066 ☔ View full report in Codecov by Sentry. |
2d9fb4a
to
7ce5532
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good :) And the panel is excellent, you can add a screenshot in the PR description for nostalgia later haha
Two things:
- Avoid using $ and % accesors directly in the methods. Instead, you can use
@onready
statement and then re-use it in the code. It's cleaner then to modify the node path - No actionable now, but we can make custom controls with the predef config like focus mode inheriting the Button for example, and use CustomUiButton instead in every case
I left the approval anyway, you can merge it after the @onready thing
|
||
|
||
func _ready(): | ||
%Tree_Console.set_column_expand(0, false) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@onready var tree_console = %Tree_Console
then you'd have to change in only one part