Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add fetch&deploy profile #121

Merged
merged 6 commits into from
Dec 12, 2023
Merged

feat: add fetch&deploy profile #121

merged 6 commits into from
Dec 12, 2023

Conversation

leanmendoza
Copy link
Collaborator

@leanmendoza leanmendoza commented Dec 11, 2023 •
edited
Loading

Implement fetch/deploy profile

  • Guest account always is created at opening the explorer, it doesn't persist
  • When change realm or open the explorer, the profile is undefined until is fetched, in the case of error, it fallbacks to the default profile
  • When modify the backpack, it tries to deploy the profile, if it goes well, the main avatar changes

Other:

  • Implement rust-side promise

@leanmendoza leanmendoza marked this pull request as ready for review December 11, 2023 21:02
@leanmendoza leanmendoza force-pushed the feat/add-fetch-profile branch from a09d25a to 621aaa3 Compare December 11, 2023 23:51
@kuruk-mm kuruk-mm force-pushed the feat/add-fetch-profile branch from 0c30df7 to aaaa66c Compare December 12, 2023 02:01
@leanmendoza leanmendoza merged commit 8c16933 into main Dec 12, 2023
6 checks passed
@leanmendoza leanmendoza deleted the feat/add-fetch-profile branch December 12, 2023 11:19
@leanmendoza leanmendoza mentioned this pull request Dec 22, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kuruk-mm kuruk-mm kuruk-mm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@leanmendoza @kuruk-mm