Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: defining when a player is inside a parcel scene or not #125

Merged
merged 1 commit into from
Dec 22, 2023

Conversation

leanmendoza
Copy link
Collaborator

@leanmendoza leanmendoza commented Dec 22, 2023

Observables onEnterScene and onLeaveScene had erractic behaviour.
Now the mechanism to define if the player is in/out of the scene is independent of the transform value.
Fix corner cases

@leanmendoza leanmendoza marked this pull request as ready for review December 22, 2023 21:45
@leanmendoza leanmendoza merged commit 815fec2 into main Dec 22, 2023
3 checks passed
@leanmendoza leanmendoza deleted the fix/avatars-inside-scene branch December 22, 2023 21:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant