Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

implement video events and some fixes #126

Merged
merged 10 commits into from
Dec 27, 2023
Merged

implement video events and some fixes #126

merged 10 commits into from
Dec 27, 2023

Conversation

leanmendoza
Copy link
Collaborator

@leanmendoza leanmendoza commented Dec 26, 2023

Fixes

  • parenting camera entity
  • ensure test finished after the plan is received
  • js runtime support async while evaluating the scene code
  • typo avatar_look_at

Features

  • implement video events

@leanmendoza leanmendoza marked this pull request as ready for review December 27, 2023 19:20
@codecov-commenter
Copy link

Codecov Report

Attention: 589 lines in your changes are missing coverage. Please review.

Comparison is base (9446361) 40.61% compared to head (90aa63f) 52.44%.
Report is 4 commits behind head on main.

Files Patch % Lines
...ntraland-godot-lib/src/auth/dcl_player_identity.rs 19.76% 138 Missing ⚠️
...land-godot-lib/src/auth/with_browser_and_server.rs 0.00% 105 Missing ⚠️
.../decentraland-godot-lib/src/auth/deploy_profile.rs 0.00% 70 Missing ⚠️
...ecentraland-godot-lib/src/comms/adapter/livekit.rs 0.00% 44 Missing ⚠️
...raland-godot-lib/src/dcl/js/ethereum_controller.rs 8.33% 33 Missing ⚠️
...ot-lib/src/scene_runner/components/video_player.rs 64.55% 28 Missing ⚠️
...centraland-godot-lib/src/auth/ethereum_provider.rs 19.23% 21 Missing ⚠️
...aland-godot-lib/src/http_request/rust_requester.rs 54.05% 17 Missing ⚠️
...decentraland-godot-lib/src/avatars/avatar_scene.rs 71.69% 15 Missing ⚠️
.../decentraland-godot-lib/src/av/stream_processor.rs 51.85% 13 Missing ⚠️
... and 23 more
Additional details and impacted files
@@             Coverage Diff             @@
##             main     #126       +/-   ##
===========================================
+ Coverage   40.61%   52.44%   +11.82%     
===========================================
  Files         117      123        +6     
  Lines       14504    15172      +668     
===========================================
+ Hits         5891     7957     +2066     
+ Misses       8613     7215     -1398     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@leanmendoza leanmendoza changed the title fix: testing fixes implement video events and some fixes Dec 27, 2023
@leanmendoza leanmendoza merged commit e78fd49 into main Dec 27, 2023
3 checks passed
@leanmendoza leanmendoza deleted the fix/testing-fixes branch December 27, 2023 19:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants