Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: improve content loading #132

Merged
merged 6 commits into from
Jan 7, 2024

Conversation

leanmendoza
Copy link
Collaborator

@leanmendoza leanmendoza commented Jan 6, 2024

  • implement http requester with priority queue and only async
  • replace content mapping Dictionary by Arc
  • implement content provider in Rust
  • gltf and texture loading working async
  • wearables/avatar/backpack working async
  • download video working
  • refix auto animations gltfs
  • temp remove video player test => events not working well

replace content mapping Dictionary by Arc<ContentMapping>
implement content provider in Rust
@leanmendoza leanmendoza force-pushed the refactor/improve-content-loading branch from f4326dd to e56fd6f Compare January 6, 2024 15:22
@codecov-commenter
Copy link

codecov-commenter commented Jan 7, 2024

Codecov Report

Attention: 559 lines in your changes are missing coverage. Please review.

Comparison is base (b81bfba) 50.09% compared to head (f9ac81c) 46.30%.

Files Patch % Lines
...ntraland-godot-lib/src/content/content_provider.rs 69.88% 103 Missing ⚠️
rust/decentraland-godot-lib/src/content/gltf.rs 78.50% 72 Missing ⚠️
rust/decentraland-godot-lib/src/content/audio.rs 0.00% 69 Missing ⚠️
...t/decentraland-godot-lib/src/comms/signed_login.rs 0.00% 65 Missing ⚠️
rust/decentraland-godot-lib/src/content/video.rs 0.00% 35 Missing ⚠️
...and-godot-lib/src/http_request/request_response.rs 42.10% 22 Missing ⚠️
...-lib/src/http_request/rust_http_queue_requester.rs 77.52% 20 Missing ⚠️
...aland-godot-lib/src/content/content_notificator.rs 20.83% 19 Missing ⚠️
rust/decentraland-godot-lib/src/content/texture.rs 70.00% 18 Missing ⚠️
...traland-godot-lib/src/content/wearable_entities.rs 80.00% 17 Missing ⚠️
... and 20 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #132      +/-   ##
==========================================
- Coverage   50.09%   46.30%   -3.80%     
==========================================
  Files         124      136      +12     
  Lines       15359    16746    +1387     
==========================================
+ Hits         7694     7754      +60     
- Misses       7665     8992    +1327     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@leanmendoza leanmendoza marked this pull request as ready for review January 7, 2024 21:04
@leanmendoza leanmendoza merged commit 93025d4 into main Jan 7, 2024
3 checks passed
@leanmendoza leanmendoza deleted the refactor/improve-content-loading branch January 7, 2024 21:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants