Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: UI tests #136

Merged
merged 5 commits into from
Jan 9, 2024
Merged

fix: UI tests #136

merged 5 commits into from
Jan 9, 2024

Conversation

leanmendoza
Copy link
Collaborator

@leanmendoza leanmendoza commented Jan 9, 2024

  • fix nft classic
  • fix player look_at error
  • chore: set name to texture loaded
  • fix: bind mut twice with call_deferred
  • feat: add enable/disable raycast debugger (and cli param)
  • fix: avatar-renderer mode
  • move VoiceChat recorder to its own struct

fix player look_at error
chore: set name to texture loaded
fix: bind mut twice with call_deferred
@codecov-commenter
Copy link

Codecov Report

Attention: 116 lines in your changes are missing coverage. Please review.

Comparison is base (18ff3cd) 46.60% compared to head (793dde7) 46.71%.
Report is 1 commits behind head on main.

Files Patch % Lines
...ust/decentraland-godot-lib/src/comms/voice_chat.rs 4.76% 40 Missing ⚠️
...ust/decentraland-godot-lib/src/av/audio_context.rs 0.00% 23 Missing ⚠️
...ntraland-godot-lib/src/godot_classes/dcl_global.rs 0.00% 10 Missing ⚠️
...-lib/src/scene_runner/components/ui/ui_dropdown.rs 0.00% 10 Missing ⚠️
...dot-lib/src/scene_runner/components/ui/ui_input.rs 0.00% 10 Missing ⚠️
...aland-godot-lib/src/http_request/rust_requester.rs 0.00% 7 Missing ⚠️
rust/decentraland-godot-lib/src/av/video_stream.rs 0.00% 3 Missing ⚠️
...ecentraland-godot-lib/src/godot_classes/promise.rs 0.00% 3 Missing ⚠️
...-lib/src/scene_runner/components/pointer_events.rs 0.00% 3 Missing ⚠️
...traland-godot-lib/src/content/wearable_entities.rs 50.00% 1 Missing ⚠️
... and 6 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #136      +/-   ##
==========================================
+ Coverage   46.60%   46.71%   +0.11%     
==========================================
  Files         136      137       +1     
  Lines       16746    16829      +83     
==========================================
+ Hits         7804     7862      +58     
- Misses       8942     8967      +25     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@leanmendoza leanmendoza merged commit 91e3345 into main Jan 9, 2024
3 checks passed
@leanmendoza leanmendoza deleted the fix/ui-tests branch January 9, 2024 23:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants