Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add godot snapshots and CI to use local server to test #165

Merged
merged 5 commits into from
Jan 12, 2024

Conversation

leanmendoza
Copy link
Collaborator

@leanmendoza leanmendoza commented Jan 12, 2024

Use versioned @dcl/scene-explorer-tests package to test, and move snapshots to this repo.

@codecov-commenter
Copy link

codecov-commenter commented Jan 12, 2024

Codecov Report

Attention: 39 lines in your changes are missing coverage. Please review.

Comparison is base (c115ad1) 46.70% compared to head (1efee9c) 46.71%.
Report is 2 commits behind head on main.

Files Patch % Lines
rust/decentraland-godot-lib/src/content/gltf.rs 37.70% 38 Missing ⚠️
...ntraland-godot-lib/src/content/content_provider.rs 83.33% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #165   +/-   ##
=======================================
  Coverage   46.70%   46.71%           
=======================================
  Files         137      137           
  Lines       16829    16885   +56     
=======================================
+ Hits         7860     7887   +27     
- Misses       8969     8998   +29     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@leanmendoza leanmendoza requested a review from kuruk-mm January 12, 2024 19:28
@leanmendoza leanmendoza merged commit 8700db5 into main Jan 12, 2024
3 checks passed
@leanmendoza leanmendoza deleted the chore/use-versioned-tests branch January 12, 2024 19:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants