-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: content loading related crashes (android) #168
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leanmendoza
changed the title
Feat/add content notificator
feat: add content notificator
Jan 16, 2024
move memcpy to packed array to helper functions (fast_create_packed_byte_array_from_*) remove nop() mock ~system/CommunicationsController::sendBinary
leanmendoza
changed the title
feat: add content notificator
fix: content loading related crashes (android)
Jan 16, 2024
kuruk-mm
reviewed
Jan 16, 2024
kuruk-mm
approved these changes
Jan 16, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Greatt!! Awesome 🙌
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Avoid duplicating to load the same resource more than once, with
ContentNotificator
applied to the downloads all the shared dependencies awaits the first request.Use
tokio::fs
instead ofgodot::FileAccess
(crashing when multiple file handlers in the same file)Minor
getUserData
is called afteronStart
but it's not resolved by theasync
engine