-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add rust-feature to build without including ffmpeg
and/or livekit
#170
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leanmendoza
changed the title
feat: add rust-feature to build without including
feat: add rust-feature to build without including Jan 16, 2024
ffmpeg
and/or `li…ffmpeg
and/or livekit
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #170 +/- ##
==========================================
- Coverage 49.59% 47.65% -1.94%
==========================================
Files 139 140 +1
Lines 16841 16848 +7
==========================================
- Hits 8352 8029 -323
- Misses 8489 8819 +330 ☔ View full report in Codecov by Sentry. |
leanmendoza
commented
Jan 17, 2024
kuruk-mm
approved these changes
Jan 18, 2024
leanmendoza
commented
Jan 18, 2024
Signed-off-by: Lean Mendoza <leandro@decentraland.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add feature-flag to include
ffmpeg
,livekit
anddeno_core/v8
by defaultThis enables an easy x86_64-android build by building it without default features (removing all of them).