Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add rust-feature to build without including ffmpeg and/or livekit #170

Merged
merged 9 commits into from
Jan 18, 2024

Conversation

leanmendoza
Copy link
Collaborator

@leanmendoza leanmendoza commented Jan 16, 2024

Add feature-flag to include ffmpeg, livekit and deno_core/v8 by default
This enables an easy x86_64-android build by building it without default features (removing all of them).

@leanmendoza leanmendoza changed the title feat: add rust-feature to build without including ffmpeg and/or `li… feat: add rust-feature to build without including ffmpeg and/or livekit Jan 16, 2024
@codecov-commenter
Copy link

codecov-commenter commented Jan 16, 2024

Codecov Report

Attention: 25 lines in your changes are missing coverage. Please review.

Comparison is base (fb785e6) 49.59% compared to head (673f5cb) 47.65%.

Files Patch % Lines
...-godot-lib/src/scene_runner/components/material.rs 10.00% 9 Missing ⚠️
...ot-lib/src/scene_runner/components/video_player.rs 0.00% 5 Missing ⚠️
...t/decentraland-godot-lib/src/scene_runner/scene.rs 0.00% 4 Missing ⚠️
...land-godot-lib/src/scene_runner/godot_dcl_scene.rs 40.00% 3 Missing ⚠️
rust/decentraland-godot-lib/src/dcl/common/mod.rs 86.66% 2 Missing ⚠️
...aland-godot-lib/src/comms/communication_manager.rs 0.00% 1 Missing ⚠️
rust/decentraland-godot-lib/src/dcl/mod.rs 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #170      +/-   ##
==========================================
- Coverage   49.59%   47.65%   -1.94%     
==========================================
  Files         139      140       +1     
  Lines       16841    16848       +7     
==========================================
- Hits         8352     8029     -323     
- Misses       8489     8819     +330     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

build-android-apk.sh Outdated Show resolved Hide resolved
.github/workflows/android-build.yml Outdated Show resolved Hide resolved
@leanmendoza leanmendoza marked this pull request as ready for review January 17, 2024 14:26
Signed-off-by: Lean Mendoza <leandro@decentraland.org>
@leanmendoza leanmendoza enabled auto-merge (squash) January 18, 2024 16:34
@leanmendoza leanmendoza merged commit 16c9523 into main Jan 18, 2024
3 checks passed
@leanmendoza leanmendoza deleted the feat/build-without-livekit-ffmpeg branch January 18, 2024 16:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants