Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: implement pointer event results #19

Merged
merged 6 commits into from
Jun 22, 2023

Conversation

leanmendoza
Copy link
Collaborator

@leanmendoza leanmendoza commented Jun 21, 2023

Also basic implementation of TextShape and Billboard

@codecov-commenter
Copy link

Codecov Report

Patch coverage: 1.90% and project coverage change: -4.12 ⚠️

Comparison is base (9ca7cdd) 30.69% compared to head (230ae6c) 26.58%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #19      +/-   ##
==========================================
- Coverage   30.69%   26.58%   -4.12%     
==========================================
  Files          33       37       +4     
  Lines        3323     3867     +544     
==========================================
+ Hits         1020     1028       +8     
- Misses       2303     2839     +536     
Impacted Files Coverage Δ
...t/decentraland-godot-lib/src/dcl/components/mod.rs 20.68% <0.00%> (-2.39%) ⬇️
...centraland-godot-lib/src/dcl/crdt/grow_only_set.rs 13.11% <0.00%> (-13.56%) ⬇️
...ust/decentraland-godot-lib/src/dcl/crdt/message.rs 0.00% <0.00%> (ø)
rust/decentraland-godot-lib/src/dcl/crdt/mod.rs 56.44% <0.00%> (-1.98%) ⬇️
rust/decentraland-godot-lib/src/dcl/js/engine.rs 0.00% <0.00%> (ø)
rust/decentraland-godot-lib/src/dcl/mod.rs 0.00% <ø> (ø)
...aland-godot-lib/src/http_request/http_requester.rs 92.72% <0.00%> (ø)
...godot-lib/src/scene_runner/components/billboard.rs 0.00% <0.00%> (ø)
...-lib/src/scene_runner/components/gltf_container.rs 0.00% <0.00%> (ø)
...-godot-lib/src/scene_runner/components/material.rs 0.00% <0.00%> (ø)
... and 11 more

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@leanmendoza leanmendoza merged commit 04e7ea2 into main Jun 22, 2023
@kuruk-mm kuruk-mm deleted the feat/implement-pointer-events branch October 24, 2024 01:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants