-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: new backpack #200
Merged
Merged
feat: new backpack #200
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #200 +/- ##
==========================================
+ Coverage 48.27% 50.86% +2.58%
==========================================
Files 142 142
Lines 17215 17215
==========================================
+ Hits 8311 8756 +445
+ Misses 8904 8459 -445 ☔ View full report in Codecov by Sentry. |
line 120 (_update_category_icon): |
await avatar loading, and show a loading spinner while is loading
debounce update avatar for backpack
…earables list) fix: fix categories pics
kuruk-mm
force-pushed
the
feat/new-backpack
branch
from
January 30, 2024 18:22
1b780bc
to
e342177
Compare
leanmendoza
approved these changes
Jan 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Need to fix:
Known issue: #210
This PR includes a fix for the emotes on Mobile too. It just changes the import of the assets.