feat: discover #211
Merged
feat: discover #211
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Icons are temporary |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #211 +/- ##
==========================================
+ Coverage 47.38% 50.32% +2.94%
==========================================
Files 144 144
Lines 17580 17619 +39
==========================================
+ Hits 8330 8867 +537
+ Misses 9250 8752 -498 ☔ View full report in Codecov by Sentry. |
|
Generated tech debt: |
leanmendoza
approved these changes
Feb 8, 2024
godot/.godot/uid_cache.bin
Outdated
There was a problem hiding this comment.
This shouldn't be commited
godot/src/config/config_data.gd
Outdated
| else: | ||
| to_remove.push_front(i) | ||
|
|
||
| for i in to_remove: |
There was a problem hiding this comment.
This works because of the way items are pushed into the vector.
Add a comment or use by_reference remove (to_remove.push(_last_places[i]) and then use erase). Don't think the performance makes a big difference here
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #224