Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: lobby #212

Merged
merged 9 commits into from
Feb 5, 2024
Merged

feat: lobby #212

merged 9 commits into from
Feb 5, 2024

Conversation

kuruk-mm
Copy link
Member

@kuruk-mm kuruk-mm commented Feb 1, 2024

Fix #153

  • New lobby with the following flow
    flow
    | Note: Discover and "Tutorial Experience" are not completed, and they are not going to be done in this PR

  • Save guest profile locally

  • Fix a bug that the colors for the skin/eye/hair of the Avatar weren't being deployed

@codecov-commenter
Copy link

codecov-commenter commented Feb 1, 2024

Codecov Report

Attention: 9 lines in your changes are missing coverage. Please review.

Comparison is base (d1a3d2b) 51.06% compared to head (4d90cd1) 50.64%.
Report is 1 commits behind head on main.

Files Patch % Lines
...ntraland-godot-lib/src/auth/dcl_player_identity.rs 0.00% 9 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #212      +/-   ##
==========================================
- Coverage   51.06%   50.64%   -0.42%     
==========================================
  Files         142      142              
  Lines       17215    17223       +8     
==========================================
- Hits         8791     8723      -68     
- Misses       8424     8500      +76     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kuruk-mm kuruk-mm marked this pull request as ready for review February 1, 2024 23:35
…r.tscn

fix: avatar emote playing for the merge
fix: bug that after avatar plays an emote, no animation is played (looks like godot bug)
@kuruk-mm kuruk-mm merged commit 15ad566 into main Feb 5, 2024
3 checks passed
@kuruk-mm kuruk-mm deleted the feat/sign-in branch February 5, 2024 16:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Lobby UI
3 participants