refactor: entity data acquisition and types

[leanmendoza]

What?

Move core types from generic dictionaries to well-known types.

• DclUserProfile
• DclAvatarWireFormat
• DclWearableEntityDefinition
• DclSceneEntityDefinition

In the case DclUserProfile, methods from_godot_dictionary and to_godot_dictionary are remained for storing purporse

The previous step was done in the UserProfile but instead of being modified directly, a Dictionary wrapper was used in the GDScript code.

[codecov-commenter]

Codecov Report

Attention: 302 lines in your changes are missing coverage. Please review.

Comparison is base (72afc69) 47.85% compared to head (ac0f01d) 48.44%.
Report is 1 commits behind head on main.

Files	Patch %	Lines
.../decentraland-godot-lib/src/avatars/avatar_type.rs	52.38%	40 Missing ⚠️
.../decentraland-godot-lib/src/dcl/common/wearable.rs	49.27%	35 Missing ⚠️
...ust/decentraland-godot-lib/src/avatars/wearable.rs	78.52%	32 Missing ⚠️
...ust/decentraland-godot-lib/src/dcl/common/scene.rs	58.57%	29 Missing ⚠️
rust/decentraland-godot-lib/src/dcl/js/runtime.rs	0.00%	22 Missing ⚠️
...godot-lib/src/realm/dcl_scene_entity_definition.rs	71.01%	20 Missing ⚠️
...decentraland-godot-lib/src/avatars/avatar_scene.rs	9.52%	19 Missing ⚠️
...nd-godot-lib/src/realm/scene_entity_coordinator.rs	66.07%	19 Missing ⚠️
...ntraland-godot-lib/src/avatars/dcl_user_profile.rs	50.00%	18 Missing ⚠️
...aland-godot-lib/src/comms/communication_manager.rs	15.78%	16 Missing ⚠️
... and 13 more

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #241      +/-   ##
==========================================
+ Coverage   47.85%   48.44%   +0.59%     
==========================================
  Files         144      152       +8     
  Lines       17636    18089     +453     
==========================================
+ Hits         8439     8763     +324     
- Misses       9197     9326     +129     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[kuruk-mm]

Can we use this PR to add the following base wearables? I can open another one anyway. But to avoid conflicts.

urn:decentraland:off-chain:base-avatars:black_glove
urn:decentraland:off-chain:base-avatars:cord_bracelet
urn:decentraland:off-chain:base-avatars:dcl_watch
urn:decentraland:off-chain:base-avatars:emerald_ring

[kuruk-mm]

Review:

chat.gd

		var avatar = Global.avatars.get_avatar_by_address(address)
		var avatar_name = (
			avatar.avatar_name if avatar != null else DclEther.shorten_eth_address(address)
		)

avatar.avatar_name doesn't exists

Repro steps: Go to Genesis Plaza and wait to receive a message

[kuruk-mm]

Review:

explorer.gd

		panel_chat.on_chats_arrived(
			[[player.avatar.avatar_id, player.avatar.avatar_name, 0, message]]
		)

avatar.avatar_name doesn't exists

Repro steps: Go to Genesis Plaza and try to talk

[kuruk-mm]

Suggested change

	fn get_thumbnail(&self) -> GString {
	fn get_thumbnail_url(&self) -> GString {

better?

[leanmendoza]

actually, I think is the hash, it directly holds the name of the property, I'd leave it

[kuruk-mm]

Great!