Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: emotes v2 #246

Merged
merged 12 commits into from
Feb 15, 2024
Merged

feat: emotes v2 #246

merged 12 commits into from
Feb 15, 2024

Conversation

leanmendoza
Copy link
Collaborator

@leanmendoza leanmendoza commented Feb 13, 2024

Fix #145

Support non-default emotes, and emotes V2 (with audio and extra meshes)

What?

  • Separate gltf loading pipeline with content_type
    • 1=Wearable doesn't generate colliders
    • 2=Emotes doesn't generate colliders and prepare emote animations
    • _=Scene Content, it generates colliders
  • Bundle default emotes, shared resource reference between avatars
  • Separate animation libraries, now, default emotes and locomotion are immutable shared resource
  • Idle animation is unique resource per avatar, it's cloned in the constructor. The tracks on it depends on equipped emotes

@codecov-commenter
Copy link

codecov-commenter commented Feb 13, 2024

Codecov Report

Attention: 47 lines in your changes are missing coverage. Please review.

Comparison is base (3ea2b95) 48.25% compared to head (a885908) 49.10%.

Files Patch % Lines
rust/decentraland-godot-lib/src/avatars/item.rs 68.04% 31 Missing ⚠️
...ntraland-godot-lib/src/content/content_provider.rs 74.19% 8 Missing ⚠️
...entraland-godot-lib/src/content/content_mapping.rs 81.25% 3 Missing ⚠️
rust/decentraland-godot-lib/src/content/gltf.rs 98.57% 2 Missing ⚠️
rust/decentraland-godot-lib/src/dcl/js/runtime.rs 0.00% 2 Missing ⚠️
...ot-lib/src/scene_runner/components/video_player.rs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #246      +/-   ##
==========================================
+ Coverage   48.25%   49.10%   +0.84%     
==========================================
  Files         152      152              
  Lines       18098    18307     +209     
==========================================
+ Hits         8734     8990     +256     
+ Misses       9364     9317      -47     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@leanmendoza leanmendoza marked this pull request as ready for review February 15, 2024 17:52
Copy link
Member

@kuruk-mm kuruk-mm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great!! 😄

enable non-equipped emotes (for avatar preview)
fix scaling breaks the emote
@leanmendoza leanmendoza enabled auto-merge (squash) February 15, 2024 21:33
@leanmendoza leanmendoza merged commit f92a006 into main Feb 15, 2024
3 checks passed
@leanmendoza leanmendoza deleted the feat/emotes-v2 branch February 15, 2024 21:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Emotes v2 (Godot)
3 participants