Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: profile snapshots upload #258

Merged
merged 11 commits into from
Feb 15, 2024
Merged

feat: profile snapshots upload #258

merged 11 commits into from
Feb 15, 2024

Conversation

kuruk-mm
Copy link
Member

@kuruk-mm kuruk-mm commented Feb 15, 2024

Fix #248

@kuruk-mm kuruk-mm force-pushed the feat/profile-snapshots-upload branch from b717ece to 1f985be Compare February 15, 2024 21:47
@codecov-commenter
Copy link

codecov-commenter commented Feb 15, 2024

Codecov Report

Attention: 65 lines in your changes are missing coverage. Please review.

Comparison is base (f92a006) 49.15% compared to head (20c69b7) 49.06%.

❗ Current head 20c69b7 differs from pull request most recent head a17b965. Consider uploading reports for the commit a17b965 to get more accurate results

Files Patch % Lines
.../decentraland-godot-lib/src/avatars/avatar_type.rs 12.00% 22 Missing ⚠️
.../decentraland-godot-lib/src/auth/deploy_profile.rs 0.00% 16 Missing ⚠️
...ntraland-godot-lib/src/auth/dcl_player_identity.rs 0.00% 14 Missing ⚠️
...traland-godot-lib/src/godot_classes/dcl_hashing.rs 18.18% 9 Missing ⚠️
...ntraland-godot-lib/src/avatars/dcl_user_profile.rs 42.85% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #258      +/-   ##
==========================================
- Coverage   49.15%   49.06%   -0.09%     
==========================================
  Files         152      153       +1     
  Lines       18307    18380      +73     
==========================================
+ Hits         8999     9019      +20     
- Misses       9308     9361      +53     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kuruk-mm kuruk-mm marked this pull request as ready for review February 15, 2024 22:54
godot/assets/themes/dark_dcl_theme/dark_dcl_theme.tres Outdated Show resolved Hide resolved
godot/assets/themes/theme.tres Outdated Show resolved Hide resolved
@kuruk-mm kuruk-mm enabled auto-merge (squash) February 15, 2024 23:14
@kuruk-mm kuruk-mm merged commit 9cc068e into main Feb 15, 2024
3 checks passed
@kuruk-mm kuruk-mm deleted the feat/profile-snapshots-upload branch February 15, 2024 23:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Profile Picture on Main HUD
3 participants