Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: triggerSceneEmote #259

Merged
merged 4 commits into from
Feb 16, 2024
Merged

feat: triggerSceneEmote #259

merged 4 commits into from
Feb 16, 2024

Conversation

leanmendoza
Copy link
Collaborator

@leanmendoza leanmendoza commented Feb 15, 2024

  • feat: enable triggerSceneEmote
  • fix: broadcasting of animation: default-emotes, emotes-v2 and scene-emotes working
  • chore: move emote logic to AvatarEmoteController class

@leanmendoza leanmendoza changed the title Feat/scene emote feat: triggerSceneRemote Feb 16, 2024
@leanmendoza leanmendoza changed the title feat: triggerSceneRemote feat: triggerSceneEmote Feb 16, 2024
@leanmendoza leanmendoza marked this pull request as ready for review February 16, 2024 14:44
@codecov-commenter
Copy link

Codecov Report

Attention: 46 lines in your changes are missing coverage. Please review.

Comparison is base (9cc068e) 49.06% compared to head (4591d87) 47.64%.

Files Patch % Lines
rust/decentraland-godot-lib/src/content/gltf.rs 0.00% 17 Missing ⚠️
...cene_runner/rpc_calls/handle_restricted_actions.rs 0.00% 14 Missing ⚠️
...entraland-godot-lib/src/content/content_mapping.rs 0.00% 8 Missing ⚠️
...decentraland-godot-lib/src/avatars/avatar_scene.rs 0.00% 6 Missing ⚠️
...ot-lib/src/scene_runner/components/avatar_shape.rs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #259      +/-   ##
==========================================
- Coverage   49.06%   47.64%   -1.42%     
==========================================
  Files         153      153              
  Lines       18380    18385       +5     
==========================================
- Hits         9018     8760     -258     
- Misses       9362     9625     +263     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@kuruk-mm kuruk-mm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!

@leanmendoza leanmendoza merged commit c386654 into main Feb 16, 2024
3 checks passed
@leanmendoza leanmendoza deleted the feat/scene-emote branch February 16, 2024 16:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants