Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: emote wheel editor #271

Merged
merged 6 commits into from
Feb 19, 2024
Merged

feat: emote wheel editor #271

merged 6 commits into from
Feb 19, 2024

Conversation

kuruk-mm
Copy link
Member

Fix #230

image

@codecov-commenter
Copy link

codecov-commenter commented Feb 18, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (886a3ca) 47.69% compared to head (2e29476) 47.70%.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main     #271   +/-   ##
=======================================
  Coverage   47.69%   47.70%           
=======================================
  Files         153      153           
  Lines       18534    18534           
=======================================
+ Hits         8840     8841    +1     
+ Misses       9694     9693    -1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

leanmendoza
leanmendoza requested changes Feb 18, 2024
View reviewed changes
Copy link
Collaborator

@leanmendoza leanmendoza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It works, and it looks good. Some minor reviews

rust/decentraland-godot-lib/src/avatars/item.rs Outdated Show resolved Hide resolved
rust/decentraland-godot-lib/src/avatars/item.rs Outdated Show resolved Hide resolved
rust/decentraland-godot-lib/src/avatars/item.rs Outdated Show resolved Hide resolved
godot/src/ui/components/emotes/emote_item_ui.gd Outdated Show resolved Hide resolved
godot/src/ui/components/emote_editor/emote_editor_item.gd Outdated Show resolved Hide resolved
godot/src/ui/components/emotes/emote_item_ui.gd Outdated Show resolved Hide resolved
godot/src/ui/components/emotes/emote_item_ui.gd Outdated Show resolved Hide resolved
@kuruk-mm kuruk-mm enabled auto-merge (squash) February 19, 2024 11:09
@kuruk-mm kuruk-mm merged commit f329ecf into main Feb 19, 2024
3 checks passed
@kuruk-mm kuruk-mm deleted the feat/emote-wheel-editor branch February 19, 2024 11:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leanmendoza leanmendoza leanmendoza approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Emote Editor UI
3 participants
@kuruk-mm @codecov-commenter @leanmendoza