Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add sdk7 to sdk6 adaption layer #36

Merged
merged 7 commits into from
Aug 29, 2023
Merged

Conversation

kuruk-mm
Copy link
Member

When an SDK6 Scene is detected, we load the SDK7 Adaption Layer.

The SDK7 Adaption Layer internally reads the scene.json and evaluates the main script from the SDK6 scene.

@codecov-commenter
Copy link

Codecov Report

Patch coverage has no change and project coverage change: -0.26% ⚠️

Comparison is base (1b4a98b) 19.84% compared to head (b552990) 19.58%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #36      +/-   ##
==========================================
- Coverage   19.84%   19.58%   -0.26%     
==========================================
  Files          56       57       +1     
  Lines        6582     6668      +86     
==========================================
  Hits         1306     1306              
- Misses       5276     5362      +86     
Files Changed Coverage Δ
...st/decentraland-godot-lib/src/dcl/js/js_runtime.rs 0.00% <0.00%> (ø)
rust/decentraland-godot-lib/src/dcl/js/mod.rs 0.00% <0.00%> (ø)
...t/decentraland-godot-lib/src/dcl/js/runtime_mod.rs 0.00% <0.00%> (ø)
rust/decentraland-godot-lib/src/dcl/mod.rs 34.48% <0.00%> (-2.56%) ⬇️
...raland-godot-lib/src/scene_runner/scene_manager.rs 0.42% <0.00%> (-0.02%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@leanmendoza leanmendoza marked this pull request as ready for review August 29, 2023 11:59
@leanmendoza leanmendoza merged commit c0aeede into main Aug 29, 2023
3 checks passed
@leanmendoza leanmendoza deleted the feat/temp-runtime-read-file branch August 29, 2023 11:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants