Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bunch of fixes #361

Merged
merged 7 commits into from
Mar 7, 2024
Merged

bunch of fixes #361

merged 7 commits into from
Mar 7, 2024

Conversation

leanmendoza
Copy link
Collaborator

@leanmendoza leanmendoza commented Mar 5, 2024

What?

  • Revert not generate collider for skinned meshes
  • Support AvatarTexture for UiBackground
  • Fix change camera mode inside AvatarModifierArea broken
  • Don't show loading screen when preview is reloading
  • Make --skip-lobby keeps the web3 session if exists
  • Send camera and player transform only when they change
  • Move RealmData inside scene-thread so it's available for APIs
    • Add SignedFetch sends proper data
  • At scene-thread spawn: removed #[allow(clippy::too_many_arguments)] by implementing a param struct
  • Update cursor_position when the canvas is resized (used by pointer raycast)

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 57.47126% with 74 lines in your changes are missing coverage. Please review.

Project coverage is 50.03%. Comparing base (08fb567) to head (6befb25).

Files Patch % Lines
rust/decentraland-godot-lib/src/dcl/mod.rs 13.88% 31 Missing ⚠️
...traland-godot-lib/src/dcl/js/fetch/signed_fetch.rs 0.00% 28 Missing ⚠️
...ntraland-godot-lib/src/content/content_provider.rs 47.05% 9 Missing ⚠️
rust/decentraland-godot-lib/src/dcl/js/runtime.rs 0.00% 5 Missing ⚠️
...d-godot-lib/src/godot_classes/dcl_ui_background.rs 90.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #361      +/-   ##
==========================================
+ Coverage   49.66%   50.03%   +0.37%     
==========================================
  Files         155      154       -1     
  Lines       19061    19113      +52     
==========================================
+ Hits         9466     9563      +97     
+ Misses       9595     9550      -45     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@leanmendoza leanmendoza changed the title wip bunch of fixes Mar 7, 2024
@leanmendoza leanmendoza marked this pull request as ready for review March 7, 2024 11:11
@leanmendoza leanmendoza requested a review from kuruk-mm March 7, 2024 11:17
Copy link
Member

@kuruk-mm kuruk-mm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work! Minor changes

godot/src/main.gd Outdated Show resolved Hide resolved
rust/decentraland-godot-lib/src/avatars/avatar_type.rs Outdated Show resolved Hide resolved
@leanmendoza leanmendoza enabled auto-merge (squash) March 7, 2024 11:58
@leanmendoza leanmendoza merged commit 4b96d11 into main Mar 7, 2024
3 checks passed
@leanmendoza leanmendoza deleted the fix/interaction branch March 7, 2024 12:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants