feat: ui sounds and avatar sfxs #411
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
add music/ambient setting to the audio settings
leanmendoza
approved these changes
May 6, 2024
There was a problem hiding this comment.
Maybe this node could inherit AudioStreamPlayer instead of adding a child to control it.
There was a problem hiding this comment.
It makes sense. But I thought about scaling the component for ambience sounds + music or something like that to have more than one AudioStreamPlayer
leanmendoza
approved these changes
May 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #405
The sounds of the remote avatars depend on the animations... sometimes the decision on when to play, walk/run/land/etc., makes the noises look wrong. But it is in sync with the animation. This should be fixed in the prediction algorithm.