-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: memory issues #414
fix: memory issues #414
Conversation
add resizing to the images for low the memory restore promise to object remove some assets that are not being used
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work! It looks good.
Something I'm not really sure, using queue_free instead of remove_child it's ok in terms of memory management, but is it desirable to keep it parented to the given node until the end of the frame?
You also have commented code with remove_child
if self.tick >= 1.0 { | ||
self.tick = 0.0; | ||
|
||
self.cached = self |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wouldn't it be better to use self.cached.retain() and mutate it instead of creating a new one each time? Even with this rate 1/sec, it makes more sense
rust/decentraland-godot-lib/src/godot_classes/resource_locker.rs
Outdated
Show resolved
Hide resolved
update num-derive to clean all clippy warnings
Fix #415