Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: resource provider #416

Merged
merged 36 commits into from
Jun 20, 2024
Merged

fix: resource provider #416

merged 36 commits into from
Jun 20, 2024

Conversation

kuruk-mm
Copy link
Member

@kuruk-mm kuruk-mm commented May 15, 2024

  • New ResourceProvider (downloads and control cache in the folder)
  • Add concurrent downloads to 32 when is in loading screen, and return to 6 (like always) when is playing
  • Add Max Cache Size to the Settings
  • Load textures and audios from memory when it is possible (when it is not in the folder cache, and it is downloaded)
  • Test more and fix crash on iPhone

kuruk-mm added 4 commits May 15, 2024 16:37
add settings for cache control
see how much disk space is using
increase concurrent downloads to 32 on loading screen
fix: issue in the resource provider on the initialization
some improvements and bug fixes
@kuruk-mm kuruk-mm force-pushed the fix/resource-provider branch from 53d2462 to 9af0668 Compare May 16, 2024 19:13
@kuruk-mm kuruk-mm requested a review from leanmendoza May 16, 2024 21:42
@kuruk-mm kuruk-mm changed the base branch from main to refactor/update-livekit June 16, 2024 12:12
@kuruk-mm kuruk-mm marked this pull request as draft June 16, 2024 12:22
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 76.92308% with 129 lines in your changes missing coverage. Please review.

Please upload report for BASE (refactor/update-livekit@70366d0). Learn more about missing BASE report.

Files Patch % Lines
...traland-godot-lib/src/content/resource_provider.rs 82.32% 64 Missing ⚠️
...ntraland-godot-lib/src/content/content_provider.rs 62.25% 57 Missing ⚠️
rust/decentraland-godot-lib/src/content/audio.rs 0.00% 4 Missing ⚠️
rust/decentraland-godot-lib/src/content/video.rs 0.00% 2 Missing ⚠️
...ntraland-godot-lib/src/auth/dcl_player_identity.rs 0.00% 1 Missing ⚠️
...ust/decentraland-godot-lib/src/av/video_context.rs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@                    Coverage Diff                     @@
##             refactor/update-livekit     #416   +/-   ##
==========================================================
  Coverage                           ?   51.96%           
==========================================================
  Files                              ?      162           
  Lines                              ?    19073           
  Branches                           ?        0           
==========================================================
  Hits                               ?     9911           
  Misses                             ?     9162           
  Partials                           ?        0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kuruk-mm kuruk-mm force-pushed the refactor/update-livekit branch from 7e1b4a7 to f309e08 Compare June 18, 2024 00:23
@leanmendoza leanmendoza mentioned this pull request Jun 18, 2024
2 tasks
Base automatically changed from refactor/update-livekit to main June 18, 2024 13:11
@kuruk-mm kuruk-mm marked this pull request as ready for review June 20, 2024 19:17
@kuruk-mm kuruk-mm merged commit 48e7fa3 into main Jun 20, 2024
4 checks passed
@kuruk-mm kuruk-mm deleted the fix/resource-provider branch June 20, 2024 19:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants